Skip to content

Fixed bug in recipe.yaml with "true" and "false" strings#46

Merged
jan-janssen merged 2 commits into
conda-forge:mainfrom
das-intensity:jinja-fix
Mar 15, 2025
Merged

Fixed bug in recipe.yaml with "true" and "false" strings#46
jan-janssen merged 2 commits into
conda-forge:mainfrom
das-intensity:jinja-fix

Conversation

@das-intensity

@das-intensity das-intensity commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

It seems these "true" and "false" strings don't work as expected.

Using "true" and "false" in cuda build:

 │ │ Resolving build environment:
 │ │   Platform: linux-64 [__unix=0=0, __linux=6.13.5=0, __glibc=2.34=0, __cuda=12.6=0, __archspec=1=zen2]
 │ │   Channels:
 │ │    - file:///home/conda/feedstock_root/build_artifacts/
 │ │    - conda-forge
 │ │   Specs:
 │ │    - gxx_linux-64 13.*
 │ │    - sysroot_linux-64 2.17.*
 │ │    - git
 │ │

Using "enabled" and "disabled" in cuda build:

 │ │ Resolving build environment:
 │ │   Platform: linux-64 [__unix=0=0, __linux=6.13.5=0, __glibc=2.34=0, __cuda=12.6=0, __archspec=1=zen2]
 │ │   Channels:
 │ │    - file:///home/conda/feedstock_root/build_artifacts/
 │ │    - conda-forge
 │ │   Specs:
 │ │    - gxx_linux-64 13.*
 │ │    - sysroot_linux-64 2.17.*
 │ │    - git
 │ │    - cuda-nvcc_linux-64 12.6.*
 │ │    - cuda-version ==12.6
 │ │

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin

conda-forge-admin commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/recipe.yaml:

  • ℹ️ Jinja2 variable references are suggested to take a ${{<one space><variable name><one space>}} form. See lines [5].
  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13867303562. Examine the logs at this URL for more detail.

@das-intensity

Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

It seems these `"true"` and `"false"` strings don't work as expected.

Using `"true"` and `"false"` in cuda build:
```
 │ │ Resolving build environment:
 │ │   Platform: linux-64 [__unix=0=0, __linux=6.13.5=0, __glibc=2.34=0, __cuda=12.6=0, __archspec=1=zen2]
 │ │   Channels:
 │ │    - file:///home/conda/feedstock_root/build_artifacts/
 │ │    - conda-forge
 │ │   Specs:
 │ │    - gxx_linux-64 13.*
 │ │    - sysroot_linux-64 2.17.*
 │ │    - git
 │ │
```

Using `"enabled"` and `"disabled"` in cuda build:
```
 │ │ Resolving build environment:
 │ │   Platform: linux-64 [__unix=0=0, __linux=6.13.5=0, __glibc=2.34=0, __cuda=12.6=0, __archspec=1=zen2]
 │ │   Channels:
 │ │    - file:///home/conda/feedstock_root/build_artifacts/
 │ │    - conda-forge
 │ │   Specs:
 │ │    - gxx_linux-64 13.*
 │ │    - sysroot_linux-64 2.17.*
 │ │    - git
 │ │    - cuda-nvcc_linux-64 12.6.*
 │ │    - cuda-version ==12.6
 │ │
```
@das-intensity

Copy link
Copy Markdown
Contributor Author

@conda-forge-admin, please rerender

@jan-janssen jan-janssen merged commit 27ab4d2 into conda-forge:main Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants